Interrupt transfers requiring several transactions are not supported by
submit_int_msg() because bInterval is ignored. This patch returns a failure code
and prints an error message in this case.

Signed-off-by: Benoît Thébaudeau <benoit.thebaud...@advansee.com>
Cc: Marek Vasut <ma...@denx.de>
Cc: Ilya Yanok <ilya.ya...@cogentembedded.com>
Cc: Stefan Herbrechtsmeier <ste...@herbrechtsmeier.net>
---
Changes for v2: N/A.
Changes for v3:
 - New patch.

 .../drivers/usb/host/ehci-hcd.c                    |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git u-boot-usb-8d5fb14.orig/drivers/usb/host/ehci-hcd.c 
u-boot-usb-8d5fb14/drivers/usb/host/ehci-hcd.c
index 1977c28..a4c84a3 100644
--- u-boot-usb-8d5fb14.orig/drivers/usb/host/ehci-hcd.c
+++ u-boot-usb-8d5fb14/drivers/usb/host/ehci-hcd.c
@@ -836,8 +836,17 @@ int
 submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
               int length, int interval)
 {
-
        debug("dev=%p, pipe=%lu, buffer=%p, length=%d, interval=%d",
              dev, pipe, buffer, length, interval);
+
+       /*
+        * Interrupt transfers requiring several transactions are not supported
+        * because bInterval is ignored.
+        */
+       if (length > usb_maxpacket(dev, pipe)) {
+               printf("%s: Interrupt transfers requiring several transactions "
+                       "are not\nsupported.\n", __func__);
+               return -1;
+       }
        return ehci_submit_async(dev, pipe, buffer, length, NULL);
 }
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to