Scott Wood <scottw...@freescale.com> wrote on 2012/07/20 23:12:49:
> From: Scott Wood <scottw...@freescale.com>
> To: Joakim Tjernlund <joakim.tjernl...@transmode.se>,
> Cc: <u-boot@lists.denx.de>
> Date: 2012/07/20 23:12
> Subject: Re: [U-Boot] [PATCH 1/2] powerpc: Stack Pointer must be 16 aligned
>
> On 07/20/2012 04:20 AM, Joakim Tjernlund wrote:
> > The PowerPC ABI mandates the SP to be 16 bytes aligned, make is so.
> >
> > Signed-off-by: Joakim Tjernlund <joakim.tjernl...@transmode.se>
> > ---
> > arch/powerpc/lib/board.c | 5 ++---
> > 1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git arch/powerpc/lib/board.c arch/powerpc/lib/board.c
> > index d5b75e5..dc7cc40 100644
> > --- arch/powerpc/lib/board.c
> > +++ arch/powerpc/lib/board.c
> > @@ -521,9 +521,8 @@ void board_init_f(ulong bootflag)
> > addr_sp -= 16;
> > addr_sp &= ~0xF;
> > s = (ulong *) addr_sp;
> > - *s-- = 0;
> > - *s-- = 0;
> > - addr_sp = (ulong) s;
> > + *s = 0; /* NULL Back Chain */
> > + *--s = 0; /* NULL LR */
>
> Same problems as in patch 2/2.
Right, that should be
*s = 0; /* NULL Back Chain */
*++s = 0; /* NULL LR */
Jocke
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
