Dear Prafulla Wadaskar, [...]
> > diff --git a/arch/arm/cpu/arm926ejs/kirkwood/dram.c > > b/arch/arm/cpu/arm926ejs/kirkwood/dram.c > > index 181b3e7..d938578 100644 > > --- a/arch/arm/cpu/arm926ejs/kirkwood/dram.c > > +++ b/arch/arm/cpu/arm926ejs/kirkwood/dram.c > > @@ -32,6 +32,12 @@ DECLARE_GLOBAL_DATA_PTR; > > > > #define KW_REG_CPUCS_WIN_BAR(x) (KW_REGISTER(0x1500) + (x * > > > > 0x08)) > > > > #define KW_REG_CPUCS_WIN_SZ(x) (KW_REGISTER(0x1504) + (x * > > > > 0x08)) > > Hi Gerlando > I have a full ack for this patch. > But I would like to ask you- > Since dram.c is going through this change and macros are being used in > stead of c-struct for DRAM register variables. This is being one of the > todo item pending from long time. > > Would you like to convert macros to c-struct definition in this file? Certainly, but let's get this applied first. [...] > > diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h > > b/arch/arm/include/asm/arch-kirkwood/cpu.h > > index d28c51a..807154e 100644 > > --- a/arch/arm/include/asm/arch-kirkwood/cpu.h > > +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h > > @@ -159,6 +159,8 @@ void reset_cpu(unsigned long ignored); > > > > unsigned char get_random_hex(void); > > unsigned int kw_sdram_bar(enum memory_bank bank); > > unsigned int kw_sdram_bs(enum memory_bank bank); > > > > +void kw_sdram_bs_set(enum memory_bank bank, u32 size); > > + > > Please remove this additional line Well, maybe you can remove it in the application process since it's really one small thing? > > int kw_config_adr_windows(void); > > void kw_config_gpio(unsigned int gpp0_oe_val, unsigned int > > > > gpp1_oe_val, > > > > unsigned int gpp0_oe, unsigned int gpp1_oe); > > > > -- > > Regards... > Prafulla . . . > > > 1.7.1 Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
