> -----Original Message----- > From: Luka Perkov [mailto:ub...@lukaperkov.net] > Sent: 19 July 2012 20:45 > To: u-boot@lists.denx.de > Cc: wojciech.dubo...@neratec.com; t...@night-shade.org.uk; Prafulla > Wadaskar > Subject: [PATCH v2] kirkwood: add support for Iomega iConnect board > > Add support for new board iConnect from Iomega. > > More information about the device can be found here: > > http://go.iomega.com/en/products/network-storage-desktop/wireless- > data-station/network-hard-drive-iconnect/?partner=4735 > > Signed-off-by: Luka Perkov <ub...@lukaperkov.net> > Tested-by: Wojciech Dubowik <wojciech.dubo...@neratec.com> > Tested-by: Tim Fletcher <t...@night-shade.org.uk> > --- > > Changes from v1: > > * remove #ifdef CONFIG_CMD_IDE part from include/configs/iconnect.h > (board does not have IDE ports) > * add compression defines in include/configs/iconnect.h > > MAINTAINERS | 1 + > board/iomega/iconnect/Makefile | 43 ++++++++++ > board/iomega/iconnect/iconnect.c | 107 +++++++++++++++++++++++ > board/iomega/iconnect/iconnect.h | 39 +++++++++ > board/iomega/iconnect/kwbimage.cfg | 165 > ++++++++++++++++++++++++++++++++++++
Is this file (kwbimage.cfg) 100% clone from any existing file already mainlined? > boards.cfg | 1 + > include/configs/iconnect.h | 129 > ++++++++++++++++++++++++++++ > 7 files changed, 485 insertions(+) > ...snip... > diff --git a/board/iomega/iconnect/iconnect.c > b/board/iomega/iconnect/iconnect.c > new file mode 100644 > index 0000000..6ee3b84 > --- /dev/null > +++ b/board/iomega/iconnect/iconnect.c > @@ -0,0 +1,107 @@ > +/* > + * Copyright (C) 2009-2012 > + * Wojciech Dubowik <wojciech.dubo...@neratec.com> > + * Luka Perkov <ub...@lukaperkov.net> > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see > <http://www.gnu.org/licenses/>. > + */ > + > +#include <common.h> > +#include <miiphy.h> > +#include <asm/arch/cpu.h> > +#include <asm/arch/kirkwood.h> > +#include <asm/arch/mpp.h> > +#include "iconnect.h" > + > +DECLARE_GLOBAL_DATA_PTR; > + > +int board_early_init_f(void) > +{ > + /* > + * default gpio configuration > + * There are maximum 64 gpios controlled through 2 sets of > registers > + * the below configuration configures mainly initial LED status > + */ > + kw_config_gpio(ICONNECT_OE_VAL_LOW, > + ICONNECT_OE_VAL_HIGH, > + ICONNECT_OE_LOW, ICONNECT_OE_HIGH); > + > + /* Multi-Purpose Pins Functionality configuration */ > + u32 kwmpp_config[] = { > + MPP0_NF_IO2, > + MPP1_NF_IO3, > + MPP2_NF_IO4, > + MPP3_NF_IO5, > + MPP4_NF_IO6, > + MPP5_NF_IO7, > + MPP6_SYSRST_OUTn, > + MPP7_GPO, > + MPP8_TW_SDA, > + MPP9_TW_SCK, > + MPP10_UART0_TXD, > + MPP11_UART0_RXD, > + MPP12_GPO, > + MPP13_SD_CMD, > + MPP14_SD_D0, > + MPP15_SD_D1, > + MPP16_SD_D2, > + MPP17_SD_D3, > + MPP18_NF_IO0, > + MPP19_NF_IO1, > + MPP20_GE1_0, > + MPP21_GE1_1, > + MPP22_GE1_2, > + MPP23_GE1_3, > + MPP24_GE1_4, > + MPP25_GE1_5, > + MPP26_GE1_6, > + MPP27_GE1_7, > + MPP28_GPIO, > + MPP29_GPIO, > + MPP30_GE1_10, > + MPP31_GE1_11, > + MPP32_GE1_12, > + MPP33_GE1_13, > + MPP34_GE1_14, > + MPP35_GPIO, > + MPP36_AUDIO_SPDIFI, > + MPP37_AUDIO_SPDIFO, > + MPP38_GPIO, > + MPP39_TDM_SPI_CS0, > + MPP40_TDM_SPI_SCK, > + MPP41_GPIO, > + MPP42_GPIO, > + MPP43_GPIO, > + MPP44_GPIO, > + MPP45_GPIO, > + MPP46_GPIO, > + MPP47_GPIO, > + MPP48_GPIO, > + MPP49_GPIO, > + 0 > + }; As per your schematics, please document possible MPPs being used for what purpose. > + kirkwood_mpp_conf(kwmpp_config, NULL); > + return 0; > +} > + > +int board_init(void) > +{ > + /* adress of boot parameters */ > + gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100; > + > + return 0; > +} ...snip... > diff --git a/include/configs/iconnect.h b/include/configs/iconnect.h > new file mode 100644 > index 0000000..125464a > --- /dev/null > +++ b/include/configs/iconnect.h > @@ -0,0 +1,129 @@ > +/* > + * (C) Copyright 2009-2012 > + * Wojciech Dubowik <wojciech.dubo...@neratec.com> > + * Luka Perkov <ub...@lukaperkov.net> > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see > <http://www.gnu.org/licenses/>. > + */ > + > +#ifndef _CONFIG_ICONNECT_H > +#define _CONFIG_ICONNECT_H > + > +/* > + * Version number information > + */ > +#define CONFIG_IDENT_STRING " Iomega iConnect Wireless" The strings looks to be too long, is it possible to shorten it? Reset other thinks looks okay to me. Regards... Prafulla . . . _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
