Dear Stefano Babic,

> On 09/07/2012 03:33, Marek Vasut wrote:
> > This makes it easier to adapt for addition of DMA support.
> > 
> > Signed-off-by: Marek Vasut <ma...@denx.de>
> > Cc: Fabio Estevam <feste...@freescale.com>
> > Cc: Otavio Salvador <ota...@ossystems.com.br>
> > Cc: Stefano Babic <sba...@denx.de>
> > Cc: Wolfgang Denk <w...@denx.de>
> > ---

[...]

> You do not need this if-then-else chain. I think is more readable with :

I think you're right ;-)

>       if (din && dout) {
>               /* Half-duplex only */
>               return -EINVAL;
>       }
>       if (!din && !dout) {
>               /* No data */
>               return 0;
>       }
> 
> 
> Best regards,
> Stefano Babic

Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to