On Tue, Jul 03, 2012 at 05:41:56PM -0500, Kim Phillips wrote: > This warning was introduced in 436da3c "ext2load: increase read > speed": > > ext2fs.c: In function 'ext2fs_read_file': > ext2fs.c:458:19: warning: 'blocknxt' may be used uninitialized in this > function [-Wuninitialized] > > this change makes it go away. > > Cc: Eric Nelson <eric.nel...@boundarydevices.com> > Cc: Thierry Reding <thierry.red...@avionic-design.de> > Cc: Jason Cooper <u-b...@lakedaemon.net> > Cc: Andreas Bießmann <andreas.de...@googlemail.com> > Cc: Reinhard Arlt <reinhard.a...@esd-electronics.com> > Signed-off-by: Kim Phillips <kim.phill...@freescale.com>
Acked-By: Jason Cooper <u-b...@lakedaemon.net> thx, Jason. > --- > v2: changed to Thierry's recommendation in: > > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/134043 > > build-tested only - please ack > > fs/ext2/ext2fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c > index f1fce48..182f0ac 100644 > --- a/fs/ext2/ext2fs.c > +++ b/fs/ext2/ext2fs.c > @@ -438,7 +438,7 @@ int ext2fs_read_file > } > > /* grab middle blocks in one go */ > - if (i != pos / blocksize && i != blockcnt - 1 && blockcnt > 3) { > + if (i != pos / blocksize && i < blockcnt - 1 && blockcnt > 3) { > int oldblk = blknr; > int blocknxt; > while (i < blockcnt - 1) { > -- > 1.7.11.1 > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
