On Sat, Jun 30, 2012 at 6:15 AM, Marek Vasut <ma...@denx.de> wrote: > Dear Harman Sohanpal, > >> These patches add USB support in u-boot for AM335x. >> The support for host or device is selected >> depending on the config selected from boards.cfg file. >> Host mode is selected for USB1 and device mode is >> selected for USB0. >> Base addresses are selected accordingly. >> >> Gene Zarkhin (1): >> AM335x : Add USB support for AM335x in u-boot >> >> Harman Sohanpal (2): >> AM335x : Configs to add USB host support. >> musb_udc : Fix compile warning. > > Dumb question ... but, can this not be made part of am35x USB ? Hi Marek, Well this can always be made part of am35x.c. But there would be a lot of changes required in the file. And also I believe it would not make much sense. It would require ifdefs at a lot of places. Best example I can give to support what i said is that the control register is at an offset of 4 in am35x and 14 in am335x. I am sure adding an ifdef at that place would not seem good to you to change address from 4 to 14 acc to platform. Is there much pain to add these 2 files? In my opinion we must need to have a separate file for this. This is as per my understanding. It could also cause confusions to some due to name. maybe :) Kindly give your thoughts. In case still some changes are required, we can think upon it :) Thanks, Harman
>> drivers/usb/musb/Makefile | 1 + >> drivers/usb/musb/am335x.c | 121 >> ++++++++++++++++++++++++++++++++++++++++++ drivers/usb/musb/am335x.h | >> 113 +++++++++++++++++++++++++++++++++++++++ drivers/usb/musb/musb_core.h | >> 2 + >> drivers/usb/musb/musb_hcd.h | 3 - >> include/configs/am335x_evm.h | 41 ++++++++++++++ >> include/usb.h | 3 +- >> 7 files changed, 280 insertions(+), 4 deletions(-) >> create mode 100644 drivers/usb/musb/am335x.c >> create mode 100644 drivers/usb/musb/am335x.h > > Best regards, > Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
