On 12-06-18 11:59 AM, Tom Rini wrote: > On Mon, Jun 18, 2012 at 10:35:34AM -0600, mathieu.poir...@linaro.org wrote: > > [snip] >> diff --git a/include/configs/snowball.h b/include/configs/snowball.h >> new file mode 100644 >> index 0000000..845db29 >> --- /dev/null >> +++ b/include/configs/snowball.h >> @@ -0,0 +1,274 @@ >> +/* >> + * Copyright (C) ST-Ericsson SA 2009 >> + * >> + * See file CREDITS for list of people who contributed to this >> + * project. >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of >> + * the License, or (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, >> + * MA 02111-1307 USA >> + */ >> + >> +#ifndef __CONFIG_H >> +#define __CONFIG_H >> + >> +/* >> + * #define DEBUG 1 >> + */ >> + >> +#define CONFIG_SKIP_LOWLEVEL_INIT 1 >> +#define CONFIG_SNOWBALL 1 >> +#define CONFIG_SYS_ICACHE_OFF 1 >> +#define CONFIG_SYS_DCACHE_OFF 1 > > Whitespace and just do '#define CONFIG_FOO' not '#define CONFIG_FOO 1'.
Weird, checkpatch.pl didn't complain. > > [snip] >> +#ifdef CONFIG_BOOT_SRAM >> +#define CONFIG_ENV_SIZE (32*1024) >> +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 64*1024) >> +#else >> +#define CONFIG_ENV_SIZE (128*1024) >> +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 256*1024) >> +#endif > > I assume you build a U-Boot for an initial loader and then a fuller > U-Boot that runs in DRAM? This is what SPL is for and I hope you will > convert at some point :) This board has a SPL but it is not compiled from this code base. I will remove the extra lines. > > [snip] >> +/* >> + * Stack sizes >> + * >> + * The stack sizes are set up in start.S using the settings below >> + */ >> + >> +#ifdef CONFIG_USE_IRQ >> +#define CONFIG_STACKSIZE_IRQ (4*1024) /* IRQ stack */ >> +#define CONFIG_STACKSIZE_FIQ (4*1024) /* FIQ stack */ >> +#endif > > I don't believe CONFIG_USE_IRQ was set, so these shouldn't be here. Correct - IRQs aren't used. > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
