Hi Allen, On Mon, Jun 11, 2012 at 12:05 PM, Allen Martin <amar...@nvidia.com> wrote:
> On Sat, Jun 09, 2012 at 11:35:29AM -0700, Simon Glass wrote: > > Hi Allen, > > > > diff --git a/include/configs/tegra20-common-post.h > b/include/configs/tegra20-common-post.h > > index b535934..6b046bd 100644 > > --- a/include/configs/tegra20-common-post.h > > +++ b/include/configs/tegra20-common-post.h > > @@ -144,4 +144,69 @@ > > TEGRA20_DEVICE_SETTINGS \ > > BOOTCMDS_COMMON > > > > +/* overrides for SPL build here */ > > +#ifdef CONFIG_SPL_BUILD > > + > > +/* remove devicetree support */ > > +#ifdef CONFIG_OF_CONTROL > > +#undef CONFIG_OF_CONTROL > > +#endif > > + > > +/* remove SERIAL_MULTI */ > > +#ifdef CONFIG_SERIAL_MULTI > > +#undef CONFIG_SERIAL_MULTI > > +#endif > > + > > +/* remove I2C support */ > > +#ifdef CONFIG_TEGRA_I2C > > +#undef CONFIG_TEGRA_I2C > > +#endif > > +#ifdef CONFIG_CMD_I2C > > +#undef CONFIG_CMD_I2C > > +#endif > > > > This stuff is pretty ugly - would it not be better to make boards not > define this in the CONFIG_SPL_BUILD case in the first place, rather than > overriding them? As an example, I2C might be useful in SPL, but here it > would be hard (or even uglier) to add. > > That's what I had in previous versions of this series, but it seemed > even uglier, because it requires sprinkling "#ifndef CONFIG_SPL_BUILD" > through each of the tegra20 board configs. > Yes, understood. That is what other boards so, but I suppose there is no requirement to follow that. So it is fine with me. We can always change it later if we need to. Regards Simon > > -Allen > -- > nvpublic >
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
