Hi Tom, On Tue, Jun 05, 2012 at 03:58:03, Rini, Tom wrote: > On Fri, Jun 01, 2012 at 08:00:43PM +0530, Prabhakar Lad wrote: > > > From: Lad, Prabhakar <prabhakar....@ti.com> > > > > This patch adds support for MMC/SD on DA850/OMAP-L138. > [snip] > > +/* SD/MMC */ > > +#define CONFIG_MMC > > +#define CONFIG_DAVINCI_MMC_SD1 > > +#define CONFIG_MMC_MBLOCK > > CONFIG_MMC_MBLOCK isn't used anywhere in code, remove it please. Ok. > > > +#define CONFIG_GENERIC_MMC > > +#define CONFIG_DAVINCI_MMC > > + > > +#ifdef CONFIG_MMC > > +#define CONFIG_DOS_PARTITION > > +#define CONFIG_CMD_EXT2 > > +#define CONFIG_CMD_FAT > > +#define CONFIG_CMD_MMC > > +#endif > > I'm not a fan of #define FOO, then checking right away for #ifdef FOO. > Just add a comment about these only been needed when you have MMC support so > it's clear to folks working from this as a template for their custom board > they can remove it. Ok I'll add a comment over here.
Thx, --Prabhakar Lad > > -- > Tom > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
