Lucas, On Tue, May 29, 2012 at 3:18 PM, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 05/29/2012 03:47 PM, Lucas Stach wrote: >> Just stumbled upon this, while looking through the usb code. loop_count >> runs down from 10000, so the correct condition to error out is ==0. > > The code change is probably fine, but it'd be better if the commit > description stated just what was being changed and why, rather than > being conversational. > > Acked-by: Stephen Warren <swar...@wwwdotorg.org>
In addition, I'd like to see come comment in the commit msg about what HW this was tested on, what was done to test it, etc. Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
