On 05/22/2012 02:23 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <1337643054-17290-1-git-send-email-swar...@wwwdotorg.org> you 
> wrote:
>> From: Stephen Warren <swar...@nvidia.com>
>>
>> This can be useful for generic scripts. For example, rather than hard-
>> coding a script to ext2load tegra-harmony.dtb, it could load
>> ${soc}-${board}.dtb and hence not need adjustments to run on multiple
>> boards.
> ...
> 
>> +echo "#define ARCH   \"${arch}\""  >> config.h
>> +echo "#define CPU    \"${cpu}\""   >> config.h
>> +echo "#define BOARD  \"${board}\"" >> config.h
> 
> Sorry, but names like ARCH and CPU are _way_ too intrusive and likely
> to clash.  Please use something like CONFIG_SYS_ARCH_NAME etc.
> instead.

OK. Are you OK with the environment variable names? They're also common
names like arch, cpu, board, vendor, soc.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to