Dear Marek, On 2 May 2012 11:44, Marek Vasut <[email protected]> wrote: >> > +int gpio_set_value(unsigned gpio, int value) >> > +{ >> > + unsigned l = readl(GPIO_FULLPORT(gpio)); >> > + unsigned port = GPIO_FULLPORT(gpio); >> > + >> > + /* >> > + * All GPIO Port have a configuration on >> > + * 2 bits excepted the first GPIO (A) which >> > + * have only 1 bit of configuration. >> > + */ >> > + if (value) >> > + if (!GPIO_PORT(gpio)) >> > + l |= (0x1 << GPIO_BIT(gpio)); >> > + else >> > + l |= (0x3 << GPIO_BIT(gpio)); >> > + else >> > + if (!GPIO_PORT(gpio)) >> > + l &= ~(0x1 << GPIO_BIT(gpio)); >> > + else >> > + l &= ~(0x3 << GPIO_BIT(gpio)); >> >> Need brace at this if..else statement. > > I wanted to ask why, but ... C isn't python, good point ;-)
As I know, it's a rule of u-boot.. maybe. :) Thanks. Minkyu Kang. -- from. prom. www.promsoft.net _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
