Hi Marek, > Dear Lukasz Majewski, > > > This commit adds support for storing private data to Samsung's UDC > > driver. This data is afterward used by usb gadget. > > > > Signed-off-by: Lukasz Majewski <l.majew...@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > > Cc: Marek Vasut <ma...@denx.de> > > --- > > drivers/usb/gadget/s3c_udc_otg.c | 12 ++++++++++++ > > 1 files changed, 12 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/usb/gadget/s3c_udc_otg.c > > b/drivers/usb/gadget/s3c_udc_otg.c index f7f7b54..925d2f2 100644 > > --- a/drivers/usb/gadget/s3c_udc_otg.c > > +++ b/drivers/usb/gadget/s3c_udc_otg.c > > @@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int > > status); static int s3c_udc_set_halt(struct usb_ep *_ep, int value); > > static void s3c_udc_set_nak(struct s3c_ep *ep); > > > > +void set_udc_gadget_private_data(void *p) > > +{ > > + DEBUG_SETUP("%s: the_controller: 0x%p, p: 0x%p\n", > > __func__, > > + the_controller, p); > > debug() and fix this message, otherwise:
The DEBUG_SETUP macro has been used to be in sync with the already available udc driver. This driver has different DEBUG_* macros, which helps in debugging different parts of UDC driver. If this is MUST, then I will change it, otherwise I'd like to leave it alone. Is it OK with you? > > Acked-by: Marek Vasut <ma...@denx.de> Thanks, please pull them to your u-boot-usb tree. (and also the patch: http://patchwork.ozlabs.org/patch/151983/ is also acked-by) > > Damn, I shouldn't have avoided reviewing them if I knew the remaining > ones were so short. But after the first one, I was quite scared of > what's coming next. Either way, here you go, fix these few issues and > you're in mainline ;-) > > > + the_controller->gadget.dev.device_data = p; > > +} > > + > > +void *get_udc_gadget_private_data(struct usb_gadget *gadget) > > +{ > > + return gadget->dev.device_data; > > +} > > + > > static struct usb_ep_ops s3c_ep_ops = { > > .enable = s3c_ep_enable, > > .disable = s3c_ep_disable, -- Best regards, Lukasz Majewski Samsung Poland R&D Center | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot