Hi Marek, On Sun, Apr 15, 2012 at 12:41:10PM +0200, Marek Vasut wrote: > > +#define CONFIG_ENV_SIZE 0x20000 > > +#define CONFIG_ENV_OFFSET 0x80000 > > The indent is weird in here?
No. Indentation is ok, the "+" moves it, when you apply the patch it looks ok in include/configs/ib62x0.h > > +#define CONFIG_DOS_PARTITION > > +#define CONFIG_MVSATA_IDE_USE_PORT0 > > +# if defined(CONFIG_BOARD_IS_IB_NAS6210) > > +# undef CONFIG_SYS_IDE_MAXBUS > > +# define CONFIG_SYS_IDE_MAXBUS 1 > > undef > define > > Why ? To avoid this warning while compiling: include/configs/ib62x0.h:140:0: warning: "CONFIG_SYS_IDE_MAXBUS" redefined [enabled by default] include/asm/arch/config.h:131:0: note: this is the location of the previous definition include/configs/ib62x0.h:141:0: warning: "CONFIG_SYS_IDE_MAXDEVICE" redefined [enabled by default] include/asm/arch/config.h:132:0: note: this is the location of the previous definition > Also, why do you use "# define" stuff (with these spaces)? We already had this argument ;) http://lists.denx.de/pipermail/u-boot/2012-March/120591.html We agreed to keep the "#[space][space]define" convention. Thank you Marek for looking at the patch again. Regards, Luka _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
