Hi,
Thank you for reworking this patch. It is mostly okay now and I can compile
the drivers, :-). Only two minor issues, please see comments below.
On Thu, 05 Apr 2012 15:29:27 +0900
Donghwa Lee <dh09....@samsung.com> wrote:
> This patch support EXYNOS FB and FIMD display drivers.
>
> Signed-off-by: Donghwa Lee <dh09....@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
> Signed-off-by: Inki Dae <inki....@samsung.com>
> ---
> arch/arm/include/asm/arch-exynos/fb.h | 446
> +++++++++++++++++++++++++++++++++
> drivers/video/Makefile | 4 +
> drivers/video/exynos_fb.c | 129 ++++++++++
> drivers/video/exynos_fb.h | 61 +++++
> drivers/video/exynos_fimd.c | 354 ++++++++++++++++++++++++++
> 5 files changed, 994 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/include/asm/arch-exynos/fb.h
> create mode 100644 drivers/video/exynos_fb.c
> create mode 100644 drivers/video/exynos_fb.h
> create mode 100644 drivers/video/exynos_fimd.c
...
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index 6252f6a..4fad20d 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -28,7 +28,11 @@ LIB := $(obj)libvideo.o
...
> COBJS-$(CONFIG_FSL_DIU_FB) += fsl_diu_fb.o videomodes.o
> +COBJS-$(CONFIG_S6E8AX0) += s6e8ax0.o
The s6e8ax0 driver is added in another patch, so please move
COBJS-$(CONFIG_S6E8AX0) += s6e8ax0.o to the patch which adds s6e8ax0
driver.
...
> diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
> new file mode 100644
> index 0000000..c6aaecf
> --- /dev/null
> +++ b/drivers/video/exynos_fb.c
...
> +static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
> +{
> + unsigned long palette_size, palette_mem_size;
> + unsigned int fb_size;
> +
> + fb_size = vid->vl_row * vid->vl_col * (vid->vl_bpix >> 3);
> +
> + lcd_base = lcdbase;
> +
> + palette_size = NBITS(vid->vl_bpix) == 8 ? 256 : 16;
> + palette_mem_size = palette_size * sizeof(u32);
Now I can compile the driver and see the following warning:
exynos_fb.c: In function 'exynos_lcd_init_mem':
exynos_fb.c:52:30: warning: variable 'palette_mem_size' set but not used
[-Wunused-but-set-variable]
Please drop 'palette_mem_size' local variable here.
Thanks,
Anatolij
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
