On 03/28/2012 02:08 PM, Simon Glass wrote: > When using CONFIG_OF_CONTROL, add a check that we have a valid FDT > and panic() if not. This must be done after the console is ready. > > Signed-off-by: Simon Glass <s...@chromium.org>
Excellent. The behavior after this series is exactly what I was looking for. One query on this patch though: Is there a need for arch/arm/lib/board.c:init_sequence[] to still include the call to fdtdec_check_fdt()? After all, if the console doesn't come from FDT, then the panic() call this patch adds will show the message so there's no need to check it earlier, and if the console does come from FDT, there's little point executing that early assert() since the message goes nowhere - presumably the code that extracts the console from FDT would perform this panic if required. So, I would have just moved the call to the existing fdtdec_check_fdt() myself, rather than splitting it into two. Still, as far as I'm concerned, this comment can be addressed in a later cleanup patch. So, the series: Tested-by: Stephen Warren <swar...@wwwdotorg.org> Acked-by: Stephen Warren <swar...@wwwdotorg.org> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
