On 03/22/2012 02:56 PM, Timur Tabi wrote: > Scott Wood wrote: >> Either it's needed, or we should get rid of CONFIG_ENABLE_36BIT_PHYS >> entirely. Either way, we should test the results on e500v1 hardware. > > That macro conditionally enables support for MAS7: > > #if defined(CONFIG_ENABLE_36BIT_PHYS) > ori r0,r0,HID0_ENMAS7@l /* Enable MAS7 */ > #endif > > So I don't think we can get rid of it, otherwise I suspect an e500v1 > operating system will not work on an e500v2 part.
Fine, keep it for that (though I'd argue that if that were the concern, we should have been clearing it before we enter the OS, and the Os can set it if it wants). But what about in write_tlb, or tlb.c? There's obviously an existing attempt to avoid touching MAS7 if CONFIG_ENABLE_36BIT_PHYS is not set. Either that's unnecessary and we should remove it, or we should continue adhering to it. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
