Dear Prabhakar Kushwaha,
In message <4f56fc6d.8080...@freescale.com> you wrote:
>
> >> +#define CONFIG_ADDR_STREAMING /* toggle addr streaming */
> > What is this good for?
> >
> > It is undocumented, and there is no code that uses it.
>
> This #define is no more in used. I just copy pasted from P1010RDB.h and
> P1_P2_RDB.h.
> i will remove it.
It would be nice if you could provide an additional cleanup patch that
removes the stale #define from the other files as well.
> >> +#define CONFIG_HOSTNAME PSC9131rdb
> >> +#define CONFIG_ROOTPATH "/opt/nfsroot"
> >> +#define CONFIG_BOOTFILE "uImage"
> >> +#define CONFIG_UBOOTPATH u-boot.bin /* U-Boot image on TFTP server */
> >> +
> >> +#define CONFIG_BAUDRATE 115200
> >> +
> >> +#define CONFIG_EXTRA_ENV_SETTINGS \
> >> + "netdev=eth0\0" \
> >> + "uboot=" MK_STR(CONFIG_UBOOTPATH) "\0" \
> > Why didn't you follow my change request here? Define as "u-boot.bin"
> > so it is at least consistent with the other strings, and drop the
> > MK_STR here.
> >
> > ...
>
> The requirement is to use u-boot.bin instead of CONFIG_UBOOTPATH?
> is my understanding correct?
No. Use
#define CONFIG_UBOOTPATH "u-boot.bin" /* U-Boot image on TFTP
server */
so that you can then use
#define CONFIG_EXTRA_ENV_SETTINGS \
"netdev=eth0\0" \
"uboot=" CONFIG_UBOOTPATH "\0" \
...
without the use of MK_STR(), and all string defines are done in a
consistent way.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The nice thing about standards is that there are so many to choose
from. - Andrew S. Tanenbaum
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
