On 03/05/2012 08:39 AM, Marek Vasut wrote:
Dear Eric Nelson,
On 03/04/2012 06:49 PM, Marek Vasut wrote:
On 03/02/2012 04:39 PM, Marek Vasut wrote:
+ * Invalidate data cache over the buffer
+ */
+ addr = (uint32_t)frame;
+ size = roundup(frame_length,
CONFIG_FEC_DATA_ALIGNMENT);
+ invalidate_dcache_range(addr, addr + size);
DTTO here, frame length might not be aligned properly, or will it be?
Network stack must be properly analyzed here.
The hardware won't return an unaligned value here, so this should be
good.
Are you sure? You can't receive frame aligned to 8 bytes boundary?
Unless I'm missing something, received packet start addresses are defined
by the driver in fec_rbd_init(), the code just modified to use memalign,
so we're good here.
Ok, that's good then. I'll skim through this driver one more time tonight and
see what comes out from it.
Thanks.
I just sent V2.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
