On Friday 10 February 2012 16:51:00 Joe Hershberger wrote: > On Fri, Feb 3, 2012 at 5:51 AM, Mike Frysinger wrote: > > On Thursday 19 January 2012 19:53:07 Joe Hershberger wrote: > >> --- a/net/bootp.c > >> +++ b/net/bootp.c > >> > >> +#ifdef CONFIG_BOOTP_RANDOM_DELAY > >> +#include "net_rand.h" > >> +#endif > > > > let's push this CONFIG_xxx check into net_rand.h so we don't have to > > check it every time we include the file > > In this case, it doesn't make sense. The rand is enabled based on > other features that need it... it does not have a config of its own. > As a result, putting this in the header would make it worse. This > guard is still needed in bootp.c, since rand is only needed when that > subfeature is enabled. For link-local, it will always be included.
i'm not sure guarding the include really gains us anything. i'm inclined to just always include it and be done. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
