On 08/02/2012 14:14, Fabio Estevam wrote: > On Wed, Feb 8, 2012 at 11:08 AM, Stefano Babic <[email protected]> wrote: > >> The patch makes clear that the GPIO is configured as input. However, >> after a reset all GPIOs in the MX53 are configured as input. Do we need >> such changes ? > > I would prefer to explicitly set gpio_direction_input rather than > depending on the reset value and I think it aligns with the GPIO API > mechanism used in the kernel as well.
Ok, good reasons. Acked-by: Stefano Babic <[email protected]> Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
