Hi Stefano,
Cc'd Govindraj.
On 02/05/12 16:57, Stefano Babic wrote:
> From: Ilya Yanok <ya...@emcraft.com>
>
> This patch adds support for the HTKW mcx AM3517-based board.
> Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both
> NAND and MMC SPLs are supported.
>
> Signed-off-by: Ilya Yanok <ya...@emcraft.com>
> Signed-off-by: Stefano Babic <sba...@denx.de>
> CC: Tom Rini <tom.r...@gmail.com>
> Cc: Detlev Zundel <d...@denx.de>
[...]
> diff --git a/board/htkw/mcx/mcx.c b/board/htkw/mcx/mcx.c
> new file mode 100644
> index 0000000..dcc8707
> --- /dev/null
> +++ b/board/htkw/mcx/mcx.c
[...]
> +#ifdef CONFIG_USB_EHCI
> +static struct omap_usbhs_board_data usbhs_bdata = {
> + .port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
> + .port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
> + .port_mode[2] = OMAP_EHCI_PORT_MODE_PHY,
This looks wrong, as port3 is TLL only, so it cannot have a PHY,
or am I missing something?
> +};
> +
> +int ehci_hcd_init(void)
> +{
> + int ret;
> +
> + ret = omap_ehci_hcd_init(&usbhs_bdata);
> + if (ret < 0)
> + return ret;
> +
> + return 0;
> +}
return omap_ehci_hcd_init(&usbhs_bdata);
?
> +
> +int ehci_hcd_stop(void)
> +{
> + int ret;
> +
> + ret = omap_ehci_hcd_stop();
> + return ret;
> +}
same here:
return omap_ehci_hcd_stop();
?
[...]
--
Regards,
Igor.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
