On Thursday 26 January 2012 20:36:22 Eric Nelson wrote:
> On 01/25/2012 08:10 AM, Matthias Fuchs wrote:
> > On 24.01.2012 17:18, Eric Nelson wrote:
> >> --- a/common/cmd_sf.c
> >> +++ b/common/cmd_sf.c
> >>
> >> char *endp;
> >> struct spi_flash *new;
> >>
> >> - if (argc< 2)
> >> - return -1;
> >> -
> >> - cs = simple_strtoul(argv[1],&endp, 0);
> >> - if (*argv[1] == 0 || (*endp != 0&& *endp != ':'))
> >> +#ifndef CONFIG_SPI_FLASH_CS
> >> + if (argc< 2) {
> >> + printf("%s: missing arguments\n", __func__);
> >
> > I think this format for the error message is a little bit untypical for
> > u-boot. We do not show up the internal C function name. Better would be
> > to show the command usage, right?
>
> Looking at this area of the code in more detail, there are quite
> a few cases where improper usage silently return -1.
>
> I'm inclined to either follow that lead or toss them together
> with a "goto usage" as done in do_spi_flash().
>
> Any preferences?invalid syntax should return cmd_usage(). errors should return non-zero, not usage information. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
