On 18/01/2012 11:41, Helmut Raiger wrote: > board_mmc_init() initializes the pins of SDHC1 and > turns on V_MMC1 of the PMIC. Config adds support for EXT2 > and FAT. > > Signed-off-by: Helmut Raiger <helmut.rai...@hale.at> > ---
Hi Helmut, > +#ifdef CONFIG_CONSOLE_EXTRA_INFO > +void video_get_info_str(int line_number, char *info) This has nothing with MCC. Please extend your commit message to explain you are also adding this feature. > +{ > + u32 srev = get_cpu_rev(); > + > + switch (line_number) { > + case 2: > + sprintf(info, " CPU : Freescale i.MX31 rev %d.%d%s at %d MHz", > + (srev & 0xF0) >> 4, (srev & 0x0F), > + ((srev & 0x8000) ? " unknown" : ""), > + mxc_get_clock(MXC_ARM_CLK) / 1000000); I know it is only one line, but it is not related to your board because it is really print_cpuinfo() into a buffer. So this cpu part should be moved into the SOC place (arch/arm/cpu/arm1136/mx31/generic.c). However, which is the real reason to do that ? I have supposed that setting video as stdout it is enough to redirect all output to the LCD, and then the usual print_cpuinfo() works, without adding / duplicating function that already use printf() for the output. I do not see a lot of boards implementing video_get_info_str(), and I understand that it is a way to customize the output. However, is it the correct way ? Does print_cpuinfo() not work if redirect to the video ? I have added Anatolji (video maintainer in CC) to get his opinion. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot