On Wed, January 11, 2012 00:40, Mike Frysinger wrote:
> On Tuesday 10 January 2012 18:04:19 Michael Walle wrote:
>> --- a/common/cmd_source.c
>> +++ b/common/cmd_source.c
>>
>> +/*
>> + * Run a series of commands, separated by '\n'.
>> + * Beware, the contents of script may be modified while it is parsed.
>> + */
>> +int run_script(char *script)
>
> const
const? const char *script? script is modified while parsing, see comment
above. I wanted to avoid copying.

> also, we already have "run_command" and "run_command2", and they're both
> in
> common/main.c.  how about naming this "source_commands" and also putting
> it
> into common/main.c ?
i'm fine with that

-- 
michael

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to