Hi Simon, On 04/01/12 16:51, Simon Glass wrote: > Hi Graeme, > > On Sun, Jan 1, 2012 at 8:09 PM, Graeme Russ <graeme.r...@gmail.com> wrote: >> >> Signed-off-by: Graeme Russ <graeme.r...@gmail.com> >> --- >> arch/x86/include/asm/init_helpers.h | 39 +++++ >> arch/x86/include/asm/init_wrappers.h | 42 +++++ >> arch/x86/lib/Makefile | 2 + >> arch/x86/lib/board.c | 297 >> +++++++++------------------------- >> arch/x86/lib/init_helpers.c | 142 ++++++++++++++++ >> arch/x86/lib/init_wrappers.c | 137 ++++++++++++++++ > > What is the rationale for putting these into separate files? If you > didn't then they would be static and presumably less code size.
The rationale is to reduce board.c to a set of init function arrays, an init function execution loop and three initialisation phase (_f, _f_r, and _r) functions which should be a generic methodology for all architectures > Also for the commit message, is this really a simplification? It looks > more like you are splitting the code into separate functions. I'll change to title and commit message Regards, Graeme _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
