> Several boolean defines have a value assigned. > Remove the value as defining the symbol is enough. > > Signed-off-by: Igor Grinberg <grinb...@compulab.co.il>
I'm fine with this. How did you find it ? M > --- > include/environment.h | 8 ++++---- > tools/envcrc.c | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/environment.h b/include/environment.h > index 3c145af..1ef44f3 100644 > --- a/include/environment.h > +++ b/include/environment.h > @@ -22,7 +22,7 @@ > */ > > #ifndef _ENVIRONMENT_H_ > -#define _ENVIRONMENT_H_ 1 > +#define _ENVIRONMENT_H_ > > /************************************************************************* > * * > @@ -64,10 +64,10 @@ > # if (CONFIG_ENV_ADDR >= CONFIG_SYS_MONITOR_BASE) && \ > (CONFIG_ENV_ADDR + CONFIG_ENV_SIZE) <= \ > (CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN) > -# define ENV_IS_EMBEDDED 1 > +# define ENV_IS_EMBEDDED > # endif > # if defined(CONFIG_ENV_ADDR_REDUND) || defined(CONFIG_ENV_OFFSET_REDUND) > -# define CONFIG_SYS_REDUNDAND_ENVIRONMENT 1 > +# define CONFIG_SYS_REDUNDAND_ENVIRONMENT > # endif > # ifdef CONFIG_ENV_IS_EMBEDDED > # error "do not define CONFIG_ENV_IS_EMBEDDED in your board config" > @@ -120,7 +120,7 @@ extern unsigned long nand_env_oob_offset; > * calculated automatically (i.e. NAND), take the board opt-in. > */ > #if defined(CONFIG_ENV_IS_EMBEDDED) && !defined(ENV_IS_EMBEDDED) > -# define ENV_IS_EMBEDDED 1 > +# define ENV_IS_EMBEDDED > #endif > > /* The build system likes to know if the env is embedded */ > diff --git a/tools/envcrc.c b/tools/envcrc.c > index 51e3f54..08d2a8f 100644 > --- a/tools/envcrc.c > +++ b/tools/envcrc.c > @@ -53,15 +53,15 @@ > # endif > # if (CONFIG_ENV_ADDR >= CONFIG_SYS_MONITOR_BASE) && \ > ((CONFIG_ENV_ADDR + CONFIG_ENV_SIZE) <= (CONFIG_SYS_MONITOR_BASE + > CONFIG_SYS_MONITOR_LEN)) -# define ENV_IS_EMBEDDED 1 > +# define ENV_IS_EMBEDDED > # endif > # if defined(CONFIG_ENV_ADDR_REDUND) || defined(CONFIG_ENV_OFFSET_REDUND) > -# define CONFIG_SYS_REDUNDAND_ENVIRONMENT 1 > +# define CONFIG_SYS_REDUNDAND_ENVIRONMENT > # endif > #endif /* CONFIG_ENV_IS_IN_FLASH */ > > #if defined(ENV_IS_EMBEDDED) && !defined(CONFIG_BUILD_ENVCRC) > -# define CONFIG_BUILD_ENVCRC 1 > +# define CONFIG_BUILD_ENVCRC > #endif > > #ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
