On 12/20/2011 03:55 PM, Marek Vasut wrote:
Let imx_get_mac_from_fuse function be a common function, so that other mx28 boards can reuse it.
[snip]
+static void __set_mac_vendor(char *mac)
[snip]
It's good, but why not make it completely generic -- like mx28_adjust_mac() -- so the users can for example change the last bit of the mac depending on the NIC that's used (FEC0 or FEC1). I think I proposed that. It's only a matter of adding a parameter (nic #) and renaming it :)
What is stored in MX28EVK CUST1 fuse? It seems to be CUST0 increased by one. So maybe we should read it from there for FEC1?
It would be nice to have very generic fuse reading function that could be used to read a serial number or similar user data. I will work this out if you don't like to do it. I'm quite busy now so it might take a week or two.
-- Veli-Pekka Peltola _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
