Dear Gabe Black, In message <1322912821-32677-1-git-send-email-gabebl...@chromium.org> you wrote: > Coreboot uses a very simple "file system" called CBFS to keep track of and > allow access to multiple "files" in a ROM image. This change adds CBFS > support and some commands to use it to u-boot. These commands are: > > cbfsinit - Initialize CBFS support and pull all metadata into RAM. The end of > the ROM is an optional parameter which defaults to the standard 0xffffffff and > can be used to support multiple CBFSes in a system. The last one set up with > cbfsinit is the one that will be used. > > cbfsinfo - Print information from the CBFS header. > > cbfsls - Print out the size, type, and name of all the files in the current > CBFS. Recognized types are translated into symbolic names. > > cbfsload - Load a file from CBFS into memory. Like the similar command for fat > filesystems, you can optionally provide a maximum size. > > Also, if u-boot needs something out of CBFS very early before the heap is > configured, it won't be able to use the normal CBFS support which caches some > information in memory it allocates from the heap. This change adds a new > cbfs_file_find_uncached function which searchs a CBFS instance without > touching > the heap. > > Support for CBFS is compiled in when the CONFIG_CMD_CBFS option is specified. > > Signed-off-by: Gabe Black <gabebl...@chromium.org>
Checkpatch reports 2 errors, 15 warnings Please clean up and resubmit. Also, please use puts() instead of printf() when you have constant strings without formatting. And fix your identifiers: CamelCaps identifiers are not allowed in U-Boot. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The human race is faced with a cruel choice: work or daytime tele- vision. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot