>> + >> + if (name[0]) >> + return (-EINVAL); > > Why the parenthesis ?
Because you asked for them… But OK, I'll remove them again... >> + >> + return ( ((bank << MXS_PAD_BANK_SHIFT) & MXS_PAD_BANK_MASK) | >> + ((pin << MXS_PAD_PIN_SHIFT ) & MXS_PAD_PIN_MASK ) ); >> +} >> + >> int gpio_invalid(int gp) >> { >> if ( (gp & ~(MXS_PAD_BANK_MASK | MXS_PAD_PIN_MASK)) || > > This was there before or are we missing some previous commit here ? To apply cleanly, this patch needs the pin validity patch applied first. However, it will apply without it, yet not cleanly. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot