Hi Mike,
Thank you for the review.
I am attaching the updated patch bellow.
Few comments in a reply to your remarks/questions.
-----------------------------------------------------------------------------------------------
+void board_reset(void)
+{
+ /* workaround for weak pull ups on ssel */
+ if (CONFIG_BFIN_BOOT_MODE == BFIN_BOOT_SPI_MASTER)
+ bfin_reset_boot_spi_cs(GPIO_PF10);
+}
do you actually have this problem in the hardware ? or is this just left
over
from copying the old bf537 file ?
PR1 Appliance seems to boot from SPI FLASH properly without the
board_reset().
From the other side we use 10KOhm on the SSEL pin the same as in BF537-STAMP
I think
so I am not sure why we will have no issue if it is observed in BF537-STAMP.
Removing board_reset() for now
-----------------------------------------------------------------------------------------------
+#define CONFIG_SYS_NO_FLASH /* we have only NAND */
not true ... you have SPI too ;)
I am not sure if I understand properly.
As far as I understand the above macro enables/disables the parallel NOR
flashes.
If removed it I get building errors like
'CONFIG_SYS_MAX_FLASH_SECT' undeclared
'CONFIG_SYS_FLASH_BASE' undeclared
All those are parallel flash related I think.
Or do you refer to my comment only? Fixed.
-----------------------------------------------------------------------------------------------
+#define CONFIG_NET_MULTI 1
no longer needed -> delete
The included patch is with the above line removed as per your advice.
If I test with the 2011R1-RC3 from the ADI repository I still need it
however.
Note that I have tested the patch (with CONFIG_NET_MULTI ) against the ADI
repository
(not the mainstream) and this is what I can confirm as working on PR1
Appliance.
-----------------------------------------------------------------------------------------------
Signed-off-by: Dimitar Penev <dpn at switchfin dot org>
Cc: Mike Frysinger <vapier {AT} gentoo {DOT} org>
www.switchfin.org/patches/uBoot-pr1-v2.patch
Best Regards
Dimitar Penev
----- Original Message -----
From: "Mike Frysinger" <vap...@gentoo.org>
To: "Dimitar Penev" <d...@switchfin.org>
Cc: <u-boot@lists.denx.de>
Sent: Saturday, November 19, 2011 7:42 AM
Subject: Re: [U-Boot] [PATCH] Add PR1 Appliance - ISDN PRI board
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
