On Wed, 16 Nov 2011 08:42:07 -0700
Tom Rini <tom.r...@gmail.com> wrote:
...
> > --- a/drivers/i2c/davinci_i2c.c
> > +++ b/drivers/i2c/davinci_i2c.c
> > @@ -78,13 +78,11 @@ static int poll_i2c_irq(int mask)
> >
> > void flush_rx(void)
> > {
> > - int dummy;
> > -
> > while (1) {
> > if (!(REG(I2C_STAT) & I2C_STAT_RRDY))
> > break;
> >
> > - dummy = REG(I2C_DRR);
> > + (void)REG(I2C_DRR);
>
> This becomes:
> (void)(*(volatile unsigned int *)(I2C_DDR))
>
> So we don't need that cast. Also, can we at get a comment about what
> / why we're doing this?
Ah, thanks for the pointer. Fixed in patch v2. I think that the
code is self-explanatory and we don't need a comment. As long
there is something shifted in and placed in data reception register
we read and throw it away since this is a flush_rx().
Anatolij
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
