Dear Gerlando, In message <4eb91abd.90...@keymile.com> you wrote: > > > The whole interface is wrong. I have just extendend "env export" to > > do a similar thing. The new syntax is: > > > > env export [-t | -b | -c] [-s size] addr [var ...] > > When/where? I can't see that in the latest master branch.
Ah, I didn't actually send it yet. Done now. > > We should do exactly the same for "env > > import", i. e. make the size parameter an option to be passed with > > "-s size", and pass the names of any variables to import as additional > > arguments: > > > > env import [-t | -b | -c] [-s size] addr [var ...] > > > > This also greatly simplifies the implementation. > > Totally agree. Question is: won't that break all the existing scripts??? Yes. It _is_ an incompatible change of the API. I hate it, but mostly because I didn't chose such a format right from the beginning. My hope is that probably not too many people use these features in scripts - at least so far it's only omap3_beagle and omap3_mvblx that use "env import -t $loadaddr $filesize". It is IMO better to change this now, instead of waiting until we have more users and the problem hits us in another place, hard. > If you agree, I can post an updated patch with the same behavior for > import. Although I am bit concerned about our scripts. We would fix these, too. But agreed, incompatible API changes are always a bad thing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de About the use of language: it is impossible to sharpen a pencil with a blunt ax. It is equally vain to try to do it with ten blunt axes instead. -- Edsger Dijkstra _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
