On Wednesday 02 November 2011 06:00:07 Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > --- > > Dear All, > > This is Device Firmware Upgrade (DFU) implementation which supports data > upload and download function to devices which are equipped with a UDC.
this information belongs in the changelog (above the "---" marker)
are you working with the elinux.org guys ?
http://elinux.org/Merge_DFU_support_into_mainline_U-Boot
> board/samsung/goni/Makefile | 2 +
> board/samsung/goni/flash.c | 634
> board/samsung/goni/flash.h | 28 ++
> board/samsung/goni/goni.c | 17 +
> common/Makefile | 1 +
> common/cmd_dfu.c | 50 +++
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/dfu.c | 920
> drivers/usb/gadget/dfu.h | 171
> include/configs/s5p_goni.h | 6 +
> include/dfu.h | 31 ++
> include/flash_entity.h | 39 ++
> include/mbr.h | 49 +++
this should be split up into at least the dfu core and board-specific changes.
although i'd wonder how much of the board/samsung/ stuff is really board
specific and couldn't be generalized ...
> --- /dev/null
> +++ b/include/dfu.h
>
> +extern int usb_gadget_handle_interrupts(void);
this doesn't belong in the dfu header
> --- /dev/null
> +++ b/include/flash_entity.h
>
> +struct flash_entity {
> + char *name;
should probably be const
> --- /dev/null
> +++ b/include/mbr.h
>
> +/*
> + * Copyright (C) 2010 Samsung Electrnoics
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <linux/compiler.h>
missing ifdef protection against multiple inclusion
this also should be split out of the dfu core ... although it seems weird that
u-boot doesn't already have mbr parsing code ...
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
