This was necessary at one point, but I've been trying to get that warning to happen again so I can add it to the change message and it won't. These early patches were done 5 or 6 months ago with a different version of the repository, a different compiler, on a different system, etc., so it'd be tricky to figure out exactly what was triggering this before.
I think the changed version is genuinely more correct, but since I can't get gcc to complain now it doesn't seem like that serious a problem. I'd say take it or leave it as you see fit, and I'll try a few more things to see if I can get it to happen again. Gabe On Fri, Oct 28, 2011 at 4:23 PM, Mike Frysinger <vap...@gentoo.org> wrote: > generally the subject/changelog should be more of the form: > > cmd_nvedit: fix printf warning > > gcc warns when using %zd with size_t types since the correct format is %zu: > <insert gcc warning here> > > otherwise, the change (in theory) makes perfect sense to me ... i > would ack if not for the commit summary/log ;) > -mike >
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
