On Wed, Oct 12, 2011 at 3:29 AM, Kumar Nath, Chandan <chandan.n...@ti.com> wrote: >> -----Original Message----- >> From: Tom Rini [mailto:tom.r...@gmail.com] >> Sent: Tuesday, October 11, 2011 9:37 PM >> To: Kumar Nath, Chandan >> Cc: u-boot@lists.denx.de >> Subject: Re: [U-Boot] [PATCH 1/5] ARM:AM33XX: Added support for AM33xx >> >> On Tue, Oct 11, 2011 at 6:51 AM, Chandan Nath <chandan.n...@ti.com> >> wrote: >> > This patch adds basic support for AM33xx which is based on ARMV7 >> > Cortex A8 CPU. >> > >> > Signed-off-by: Chandan Nath <chandan.n...@ti.com> >> [snip] >> > +SRAM_STACK: >> > + /* Place stack at the top */ >> > + .word (SRAM0_START + SRAM0_SIZE - ROM_CODE_SIZE - 4) >> [snip] >> > +#define SRAM0_SIZE 0x20000 >> > +#define ROM_CODE_SIZE 0x4C00 >> >> I like that we're defining the ROM_CODE_SIZE here. For consistency >> with other platforms we should add LOW_LEVEL_SRAM_STACK to this >> calculation. Thanks! >> > > To maintain the consistency with other platform, I will use > LOW_LEVEL_SRAM_STACK > instead of this calculation. This will be addressed in the next version of > this patch set.
To be clear, I'm saying we should define LOW_LEVEL_SRAM_STACK to this calculation. Thanks again. -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
