Dear Michael Jones, In message <4e8ec11b.8040...@matrix-vision.de> you wrote: > > But while we're on the topic- Most of those old warnings were because my > board/matrix_vision/mvblx/mvblx.h was based on board/ti/beagle/beagle.h, > which would've itself had lots of checkpatch warnings from long lines. > Sandeep advised me that this was a poor argument for submitting a patch > with warnings, so I submitted v5. Now I've researched this again and > found the patch which introduced the warnings for beagle.h and the > discussion [2] around it. If it was decided back then to indent the > lines with tabs although it caused checkpatch warnings, isn't it > reasonable for mvblx.h to be formatted in the same way? I don't care > how it's formatted, but I find the inconsistency ugly.
There are a few cases where longer lines actually provide better readbility than wrapping the code - these are things like tables of MUX initializations, and the like. But "normal" code or header files has a strict 80 char line length limit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Star Trek Lives! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
