Dear Stephen Warren,
In message <74cdbe0f657a3d45afbb94109fb122ff173b23b...@hqmail01.nvidia.com> you
wrote:
>
> > But please define "first bank" - does it mena the firs one
> > initialized, or the lowest start address, or the lowest chip select,
> > or ... ?
>
> It's the following currently:
>
> gd->bd->bi_dram[0].start
>
> * How would you describe this; "the first DRAM bank registered with
> U-Boot"?
I would even add above explanation to the commen, i. e. something
like:
first DRAM bank registered with U-Boot (i. e.
bd->bi_dram[0].start).
> * Is this a good value to use, or should getenv_bootm_low() search through
> all banks to find the one with lowest address or something?
I would expect that this works on most (all?) of the existing boards;
if a board maps higher addresses first we will probably have to
discuss if this is not a bug.
> > Hm... this appears to add some additional code. How much does the
> > size grow?
>
> At least when building for Tegra, this adds 576 bytes text, and 136 bytes
> rodata. That's about a 0.4% size increase to each section.
0.4% of the total image size, not of the code size of this source
file, right?
> I guess it's possible. It'll mean a heck of a lot of ifdef's in the
> middle of all those multi-test if statements that work on a variety of
> image types though. Are the size increases above as large as you feared;
> is it worth making it optional?
0.5 KiB of code is actually quite a lot on some small systems - and
most of them will never need this feature. This is actually only
needed for ARM so far, so for a _large_ number of boards this is just
overhead.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"Data is a lot like humans: It is born. Matures. Gets married to
other data, divorced. Gets old. One thing that it doesn't do is die.
It has to be killed." - Arthur Miller
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
