On Oct 4, 2011, at 5:00 AM, Marek Vasut wrote:
>> Commit ID 60ce53cf9f40
>>
>> "GCC4.6: Convert various empty macros to inline functions"
>>
>> changed the "debug" macro to an inline function. This causes
>> the mpc8xxx ddr code to stop building because there is a debug()
>> statement that references symbols that only exist when DEBUG is
>> defined. This patch makes those symbols unconditional.
>>
>> Signed-off-by: Becky Bruce <bec...@kernel.crashing.org>
>
> NAK. This approach increases code size. The patch you mentioned is going to
> be reverted until fixed.
>
> Better fix is welcome though!
Like I said to Timur, I just need stuff to build, and this increases code size
only a tiny bit..... I'd prefer the revert, though.
-B
>
> Cheers
>
>> ---
>> arch/powerpc/cpu/mpc8xxx/ddr/main.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/main.c
>> b/arch/powerpc/cpu/mpc8xxx/ddr/main.c index 249fd7d..eb70535 100644
>> --- a/arch/powerpc/cpu/mpc8xxx/ddr/main.c
>> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/main.c
>> @@ -132,7 +132,6 @@ void fsl_ddr_get_spd(generic_spd_eeprom_t
>> *ctrl_dimms_spd, * | interleaving
>> */
>>
>> -#ifdef DEBUG
>> const char *step_string_tbl[] = {
>> "STEP_GET_SPD",
>> "STEP_COMPUTE_DIMM_PARMS",
>> @@ -153,7 +152,6 @@ const char * step_to_string(unsigned int step) {
>>
>> return step_string_tbl[s];
>> }
>> -#endif
>>
>> int step_assign_addresses(fsl_ddr_info_t *pinfo,
>> unsigned int dbw_cap_adj[],
>> --
>> 1.5.6.5
>>
>>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
