On Tuesday, September 27, 2011 10:40:26 PM Jana Rapava wrote: > 2011/9/27 Marek Vasut <marek.va...@gmail.com> > > > > diff --git a/board/efikamx/efika.h b/board/efikamx/efika.h > > > new file mode 100644 > > > index 0000000..2134e75 > > > --- /dev/null > > > +++ b/board/efikamx/efika.h > > > @@ -0,0 +1,8 @@ > > > > Proper header is missing here, with license, author etc. > > What should I write into copyright field, if I copied your code into this > header file?
You're introducing your file here, it's your stuff. > > > > +void ulpi_write(struct usb_ehci *ehci, u32 reg, u32 value) > > > +{ > > > + if (!(readl(&ehci->ulpi_viewpoint) & ULPI_SS)) { > > > + writel(ULPI_WU, &ehci->ulpi_viewpoint); > > > + ulpi_wait(ehci, ULPI_WU, "wakeup"); > > > > This function returns some value, but you're not checking it. It's > > probably if > > the wait timed out, right ? Why aren't you checking it ? > > I''ll check it, but I don't know what function calling ulpi_write/read/wait > should do if call fails. Should it write error message and return, should > it write message and return error value...? Return error value until you reach ulpi_{read/write}, write error message there ? _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot