On Thursday, September 22, 2011 06:54:22 AM Jason Hui wrote: > Hi, Marek, > > On Thu, Sep 22, 2011 at 11:43 AM, Marek Vasut <marek.va...@gmail.com> wrote: > > On Thursday, September 22, 2011 04:45:20 AM Jason Hui wrote: > >> Hi, Marek, > >> > >> On Tue, Sep 20, 2011 at 10:35 AM, Marek Vasut <marek.va...@gmail.com> wrote: > >> > Rewrite the mxc_i2c driver. > >> > * This version is much closer to Linux implementation. > >> > * Fixes IPG_PERCLK being incorrectly used as clock source > >> > * Fixes behaviour of the driver on iMX51 > >> > * Clean up coding style a bit ;-) > >> > > >> > Signed-off-by: Marek Vasut <marek.va...@gmail.com> > >> > Cc: Stefano Babic <sba...@denx.de> > >> > Cc: Heiko Schocher <h...@denx.de> > >> > Cc: Jason Hui <jason....@linaro.org> > >> > --- > >> > drivers/i2c/mxc_i2c.c | 422 > >> > +++++++++++++++++++++++++++++++++---------------- 1 files changed, 289 > >> > insertions(+), 133 deletions(-) > >> > > >> > V2: Use PERCLK as a source. > >> > > >> > V3: Remove forgotten unused variables. > >> > > >> > V4: Add missing Cc field to commit message > >> > >> Test result on i.mx53evk, it shows that this patch does not work well, > >> here is the log: > >> > >> MX53EVK U-Boot > pmic dump 10 > >> PMIC ID: 0x0000ffff [Rev: unknown] > >> > >> 0x00: 0001ffff 00ffffff 0039ffff 0000ffff 00ffffff 0000ffff 0000ffff > >> 0000ffff 0x08: 0000ffff 0000ffff 0000ffff 0000ffff 0000ffff 0000ffff > >> 0000ffff 0040ffff > > > > It's strange, reading the registers with i2c md seems to work. > > Here is i2c md output: > MX53EVK U-Boot > i2c md 8 0 > 0000: 01 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ > > seems not ok.
8 seems certainly not ok since the pmic is at 0x48 > > Jason Liu _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
