Dear "GROYER, Anthony",
In message
<bc0a2f434d4f39448d24a68ea6effb9f0194d...@eu-fr-exbe07.eu.corp.airliquide.com>
you wrote:
>
> The use of the initial patches for the CONFIG_SYS_SKIP_ARM_RELOCATION featu
> res has revealed two issues.
Could you please restict your line length to some 70 characters or so?
Thanks.
> First issue: the calculation of the relocation offset was done only if the
> relocation is actually done. So we could reach a point where r9 has a wrong
> value, since it has never been used before (in my case, this bug happens w
This is a configuration error then, isn't it? The relocation offset
should be either the intended value, or eventually zero, if no
relocation is intended.
> the test of a relocation need.
>
> Second issue: board_init_r was thinking the memory area for the malloc is j
> ust below the code, whereas the board_init_f had allocated some space for t
> he malloc at the end of the SDRAM. If the code is located at the base of th
This is a broken memory layout then, i. e. another configuration
error.
So actually both your "issues" are caused by configuration errors and
should go away if you fix your system configuration.
BTW: your patch has a number ofd coduing style errors, and the
Signed-off-by: line is missing.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Any sufficiently advanced technology is indistinguishable from magic.
- Arthur C. Clarke
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
