On Saturday, September 10, 2011 09:17:28 Andrew Murray wrote:
> +#else
> +#define DO_INITCALL(x, ...) \
> +     ({ (x)(__VA_ARGS__); })

this should be do{}while(0) to avoid differences in behavior with the other 
DO_INITCALL() helper

> +#define DO_INITCALL_END(x) \
> +     do { \
> +             printf_boot_trace("initcall 0x%pF returned\n", x); \
> +     } while (0)
> ...
> +#define DO_INITCALL_END(x)

seems like these should be merged so that dead code isnt caught in the middle

#ifdef CONFIG_BOOT_TRACE
# define _BOOT_TRACE 1
#else
# define _BOOT_TRACE 0
#endif
#define DO_INITCALL_END(x) \
        do { \
                if (_BOOT_TRACE) \
                        printf_boot_trace("initcall 0x%pF returned\n", x); \
        } while (0)

although, if printf_boot_trace() itself had CONFIG_BOOT_TRACE logic in it, you 
wouldnt have to have DO_INITCALL_END() take care of wrapping things ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to