On 09/09/2011 10:18 AM, Jin Zhengxiong-R64188 wrote: > > >> -----Original Message----- >> From: Wolfgang Denk [mailto:w...@denx.de] >> Sent: Friday, September 09, 2011 3:26 PM >> To: Jin Zhengxiong-R64188 >> Cc: Stany MARCEL; u-boot@lists.denx.de >> Subject: Re: [U-Boot] [PATCH 1/2] coldfire: Fix compilation for most coldfire >> boards >> >> Dear Jin Zhengxiong-R64188, >> >> In message <BE72CBA69B1D6F44B0680DF984332A32253A40@039-SN1MPN1- >> 005.039d.mgd.msft.net> you wrote: >>> >>>> From: Stany MARCEL [mailto:stany.mar...@novasys-ingenierie.com] >>>> Sent: Monday, September 05, 2011 9:29 PM >>>> To: u-boot@lists.denx.de >>>> Cc: Jin Zhengxiong-R64188; Jin Zhengxiong-R64188; Stany MARCEL >>>> Subject: [PATCH 1/2] coldfire: Fix compilation for most coldfire >>>> boards >>>> >>>> Many different patches to fix compilation of coldfire boards. >>>> Compilation could now be done in a different directory from the >>>> sources one. Simple board config switched from Makefile to >>>> boards.cfg EP2500 broken board removed from boards.cfg. Link files >>>> corrected to remove zlib.o and multiple defined symbols. >>>> >>>> Signed-off-by: Stany MARCEL <stany.mar...@novasys-ingenierie.com> >>>> --- >>>> MAKEALL | 6 -- >>>> Makefile | 124 +++++------------------------- >> ---- >>>> arch/m68k/cpu/mcf5227x/Makefile | 2 +- >>>> arch/m68k/cpu/mcf523x/Makefile | 2 +- >>>> arch/m68k/cpu/mcf532x/Makefile | 2 +- >>>> arch/m68k/cpu/mcf5445x/Makefile | 2 +- >>>> arch/m68k/cpu/mcf547x_8x/Makefile | 2 +- >>>> board/BuS/EB+MCF-EV123/u-boot.lds | 8 -- >>>> board/cobra5272/u-boot.lds | 7 -- >>>> board/esd/tasreg/u-boot.lds | 7 -- >>>> board/freescale/m52277evb/.gitignore | 1 + >>>> board/freescale/m5235evb/.gitignore | 1 + >>>> board/freescale/m5235evb/u-boot.16 | 8 -- >>>> board/freescale/m5235evb/u-boot.32 | 16 ----- >>>> board/freescale/m5249evb/u-boot.lds | 7 -- >>>> board/freescale/m5253evbe/u-boot.lds | 7 -- >>>> board/freescale/m5272c3/u-boot.lds | 7 -- >>>> board/freescale/m5275evb/u-boot.lds | 6 -- >>>> board/freescale/m54451evb/.gitignore | 1 + >>>> board/freescale/m54455evb/.gitignore | 1 + >>>> board/idmr/u-boot.lds | 7 -- >>>> boards.cfg | 21 ++++++- >>>> include/configs/M5329EVB.h | 8 +- >>>> 23 files changed, 50 insertions(+), 203 deletions(-) create mode >>>> 100644 board/freescale/m52277evb/.gitignore >>>> create mode 100644 board/freescale/m5235evb/.gitignore >>>> create mode 100644 board/freescale/m54451evb/.gitignore >>>> create mode 100644 board/freescale/m54455evb/.gitignore >>>> >>> [Jin Zhengxiong-R64188] >>> Please remove the unused git information from the patch. Thanks. >> >> I agree with your other comments, but what sort of "unused git information" >> are >> you referring to here? >> >> There is no "unused git information" in this patch. It is a proper patch >> generated by git-format-patch and submitted using git-send-email. >> >> There is nothing that should be changed in the format. >> > [Jin Zhengxiong-R64188] > Ok, Thanks a lot, I had thought that the .gitignore which ignore the lds > files are empty files. > > Best Regards, > Jason > > Hello,
Sorry for my late reply, I was working on another subject. My work is now separated in different patches and I also made some additional improvements. What is the best way to submit this new work ? I don't know if it must be a version two of the previous patch or a new set of patches. Here is the new list of patches' subjects: * ColdFire: Cleanup lds files for multiple defined symbols * ColdFire: Add $(obj) before cpu lib to correct build * ColdFire: Move boards with simple _config rules to boards.cfg * ColdFire: Merge differentiated linking files into a sigle one by board * ColdFire: Clean Makefile _config rules * ColdFire: Fix compilation with CONFIG_SYS_DRAMSZ1 defined For Information, for ColdFire I can only test with a M5485EVB. For other ColdFire boards I can only verify that the build is performed correctly. Best Regards, Stany _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
