Hello Stefano, Stefano Babic wrote: > On 09/08/2011 10:42 PM, Marek Vasut wrote: >> This patch supports: >> - Timers >> - Debug UART >> - Clock > > Hi Marek, > > a general remark. It seems to me that your patchset comes directly from > your development, as it looks like what I normally have when I develop a > new board ;-)
I also tend to do such things ;-) > However, to put into mainline and to make review easier, because this is > a porting to a new SOC, I am expecting that all patches related to a new > file are squashed together. It makes no sense to have several patches > regarding, for example, m28evk.h, because this is a new file. Yep, for new files, it makes sense to make only one patch. > Another general remark here: we tend to have the same structure and the > same files for all IMX SOC. This means that all IMX SOC have a > imx-regs.h that contain the required register definitions (really a > subset what we have in kernel). Is it really necessary to split the > definitions in several small files ? Hmm... is this really a good thing? If I look in the statistic below, this results in a big (lines > 1000) file ... I don;t like such big files, but this is just a personal taste ... > >> Signed-off-by: Marek Vasut <marek.va...@gmail.com> >> Cc: Stefano Babic <sba...@denx.de> >> Cc: Wolfgang Denk <w...@denx.de> >> Cc: Detlev Zundel <d...@denx.de> >> --- >> arch/arm/cpu/arm926ejs/mx28/Makefile | 46 +++ >> arch/arm/cpu/arm926ejs/mx28/clock.c | 359 ++++++++++++++++++++++ >> arch/arm/cpu/arm926ejs/mx28/mx28.c | 131 ++++++++ >> arch/arm/cpu/arm926ejs/mx28/timer.c | 143 +++++++++ >> arch/arm/include/asm/arch-mx28/clock.h | 48 +++ >> arch/arm/include/asm/arch-mx28/imx-regs.h | 33 ++ >> arch/arm/include/asm/arch-mx28/mx28.h | 30 ++ >> arch/arm/include/asm/arch-mx28/regs-base.h | 88 ++++++ >> arch/arm/include/asm/arch-mx28/regs-clkctrl.h | 308 +++++++++++++++++++ >> arch/arm/include/asm/arch-mx28/regs-common.h | 66 ++++ >> arch/arm/include/asm/arch-mx28/regs-power.h | 409 >> +++++++++++++++++++++++++ >> arch/arm/include/asm/arch-mx28/regs-ssp.h | 345 +++++++++++++++++++++ >> arch/arm/include/asm/arch-mx28/regs-timrot.h | 167 ++++++++++ >> arch/arm/include/asm/arch-mx28/regs-uartdbg.h | 182 +++++++++++ bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
