> From: Wolfgang Denk [w...@denx.de]
> Sent: Saturday, September 03, 2011 3:37 AM
> To: Premi, Sanjeev
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'
>
> Dear "Premi, Sanjeev",
>
> In message <b85a65d85d7eb246be421b3fb0fbb5930257371...@dbde02.ent.ti.com> you
> wrote:
> >
> > > Your patch always and unconditionally overwrites any existing
> > > "ethaddr" settings. This is not acceptable.
> >
> > For the EVM, MAC address is always probed from the chip. Hence, I
> > assumed it safe to set the ethaddr - without checking for env var.
>
> This is not what we do in U-Boot, so please fix that.
>
> > It was unlikely that someone would be setting it - to different
> > value.
>
> Unlikely? Not so. This is expected standard behaviour. Please don't
> try to invent a wheel (in a different shape).
[sp] I agreed with your comments in the next para. Had only
described my thoughts before creating this patch.
You seem to have missed the v2 of the same patch where I
believe I have taken care of this behavior:
http://marc.info/?l=u-boot&m=131497907619918&w=2
Do let me know if this is better...
~sanjeev
>
> Best regards,
>
> Wolfgang Denk
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
