Dear Michal Simek,

In message <[email protected]> you wrote:
>
> >> +/* Axi Ethernet registers offset */
> >> +#define XAE_IS_OFFSET             0x0000000C /* Interrupt status */
> >> +#define XAE_IE_OFFSET             0x00000014 /* Interrupt enable */
> >> +#define XAE_RCW1_OFFSET           0x00000404 /* Rx Configuration Word 1 */
> >> +#define XAE_TC_OFFSET             0x00000408 /* Tx Configuration */
> >> +#define XAE_EMMC_OFFSET           0x00000410 /* EMAC mode configuration */
> >> +#define XAE_MDIO_MC_OFFSET        0x00000500 /* MII Management Config */
> >> +#define XAE_MDIO_MCR_OFFSET       0x00000504 /* MII Management Control */
> >> +#define XAE_MDIO_MWD_OFFSET       0x00000508 /* MII Management Write Data 
> >> */
> >> +#define XAE_MDIO_MRD_OFFSET       0x0000050C /* MII Management Read Data 
> >> */
> > 
> > Please use struct xae_regs {...} as the rest of the u-boot.
> 
> struct is not useful here because it will be big with a lot of reserved 
> values.

Code based on base address + offset notation will not be accepted.
Please do use a struct as requested.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
If programming was easy, they wouldn't need something as  complicated
as a human being to do it, now would they?
                       - L. Wall & R. L. Schwartz, _Programming Perl_
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to