Dear Chunhe Lan,
In message <1314602152-9114-1-git-send-email-chunhe....@freescale.com> you
wrote:
> In the p1023rds, accessing exclusively nor flash or nand flash device by
> BR0/OR0.
...
> When booting from nor flash, the status of nor node is null that means it
> is enabled and the status of nand node is disabled in the default dts file,
> so do not do anything.
It would be more intuitive to the reader, when the enabled node would
use an explicit
status = "enabled";
> +#ifdef CONFIG_NAND_U_BOOT
> + do_fixup_by_path_string(fdt, "nor_flash", "status", "disabled");
> + do_fixup_by_path_string(fdt, "nand_flash", "status", "okay");
> +#endif
What does ""okay" mean? This is not documented anywhere. Is this
supposed to mean "enabled"? Then please write "enabled" - for certain
configurations it is definitely OK to disable the device.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There's an old story about the person who wished his computer were as
easy to use as his telephone. That wish has come true, since I no
longer know how to use my telephone.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
