Re: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors

[Andy Fleming]

On Aug 10, 2011, at 2:12 AM, Joe Hershberger wrote:

> Previously only the last N were included based on the current one in use.
> 
> Signed-off-by: Joe Hershberger <joe.hershber...@ni.com>
> Cc: Joe Hershberger <joe.hershber...@gmail.com>
> Cc: Mingkai Hu <mingkai...@freescale.com>
> Cc: Andy Fleming <aflem...@freescale.com>
> Cc: Kumar Gala <ga...@kernel.crashing.org>
> Cc: Detlev Zundel <d...@denx.de>


I'm curious if you were seeing a problem that this fixes?


> ---
> drivers/net/tsec.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
> index 78ffc95..1805ca0 100644
> --- a/drivers/net/tsec.c
> +++ b/drivers/net/tsec.c
> @@ -250,8 +250,8 @@ static void startup_tsec(struct eth_device *dev)
>       txIdx = 0;
> 
>       /* Point to the buffer descriptors */
> -     out_be32(&regs->tbase, (unsigned int)(&rtx.txbd[txIdx]));
> -     out_be32(&regs->rbase, (unsigned int)(&rtx.rxbd[rxIdx]));
> +     out_be32(&regs->tbase, (unsigned int)(&rtx.txbd[0]));
> +     out_be32(&regs->rbase, (unsigned int)(&rtx.rxbd[0]));


However, while I don't believe this fixes a technical problem, I believe this 
makes the code more straightforward.

So if this is a fix to a problem, we need more information to understand what 
you're really fixing. If this is just fixing something that looked wrong...:

Acked-by: Andy Fleming <aflem...@freescale.com>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot